Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot both creates a PR and complains about no contributions when extra text in comment #468

Closed
JoshuaKGoldberg opened this issue May 13, 2023 · 2 comments · Fixed by #489
Closed

Bot both creates a PR and complains about no contributions when extra text in comment #468

JoshuaKGoldberg opened this issue May 13, 2023 · 2 comments · Fixed by #489
Labels
bug Something isn't working released

Comments

@JoshuaKGoldberg
Copy link
Contributor

Describe the bug

With a(n accidentally) specially crafted comment, I've tricked the bot into both creating a PR and saying in the same comment that it couldn't determine any contributions:

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 🎉

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

JoshuaKGoldberg/create-typescript-app#429 (comment)

To Reproduce

Steps to reproduce the behavior:

  1. Set up allcontributors in a new repo
  2. Post a comment with content after the @all-contributors please add ... line

Expected behavior

The bot should ignore the extra content

Additional context

I posted some more comments on that PR. It looks like the bug might have something to do with text like all-contributors existing?
@JoshuaKGoldberg JoshuaKGoldberg added the bug Something isn't working label May 13, 2023
@dannogr
Copy link

dannogr commented May 26, 2023

Hello man, great job!

This was referenced Feb 17, 2024
Closed
Closed
Merged
Merged
@gr2m gr2m closed this as completed in #489 Sep 12, 2024
@gr2m gr2m closed this as completed in db6de74 Sep 12, 2024
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.19.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: only comment about no contributions after checking all contributors JoshuaKGoldberg/app
2 participants
@JoshuaKGoldberg @dannogr