Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When publishing and then locally pinning crate with custom manifest file name, crate cannot be found #1680

Open
meowthsli opened this issue May 7, 2024 · 2 comments
Labels
type: feature New feature or request

Comments

@meowthsli
Copy link

Describe the bug
When developing multi-crate application, it is useful to have pinned local repositories of crates one's making changes to. So if crate has a manifest file with non-default name (i.e. like there https://github.com/meowthsli/light-startup), you can't pin it later, cause pins directive uses path and expects to find alire.toml over there.

To Reproduce
Steps to reproduce the behavior:

  1. Create local crate with custom manifest file name.
  2. Try to pin it locally
  3. See error - crate can't be found.

Expected Behavior
It should be possible to pin to crate with custom crate manifest file names, because you can publish it with --manifest override, but you cannot pin it later.

alr version
alr version: 2.0.1
libalire version: 2.0.1
compilation date: 2024-03-21 11:30:41
compiled with version: 13.2.0

@meowthsli
Copy link
Author

Maybe, it is useful to add manifest property to pin_attributes to allow custom manifest name.

Workaround for now: add fs link to custom manifest file with alire.toml name

@mosteo mosteo added the type: feature New feature or request label May 15, 2024
@Fabien-Chouteau
Copy link
Member

We already have the subdir/monorepo feature that should work here, especially when #1683 is in.

So let's not introduce a new solution to the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants