Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong configuration files in dependencies #1385

Closed
reznikmm opened this issue May 29, 2023 · 4 comments
Closed

Wrong configuration files in dependencies #1385

reznikmm opened this issue May 29, 2023 · 4 comments
Labels
state: wontfix After consideration, this will not be worked on
Milestone

Comments

@reznikmm
Copy link
Contributor

The alr writes wrong configuration files for me in a dependencies (VSS). To reproduce:

  • alr index --add git+https://github.com/reznikmm/als-alire-index.git#v23.0.18 --name als
  • alr get ada_language_server
  • in ada_language_server_23.0.18_973e7d46/alire/cache/dependencies/vss_24.0.0_9d3df28c/config
    • vss_config.gpr misses -gnat2022 as it requested in VSS alire.toml with
      [build-switches]
      "*".ada_version = "Ada2022"
      
    • extra files vss_config.ads and vss_config.h - they are disabled in VSS alire.toml with
      [configuration]
      generate_ada = false
      generate_c = false
      
@mosteo
Copy link
Member

mosteo commented May 29, 2023

Which alr version is this? It could be related to #1355

@reznikmm
Copy link
Contributor Author

alr 1.2.1

@mosteo mosteo added the type: bug Something isn't working label May 30, 2023
@mosteo mosteo added this to the 2.0 milestone May 30, 2023
@mosteo mosteo added state: wontfix After consideration, this will not be worked on and removed type: bug Something isn't working labels Sep 12, 2023
@mosteo
Copy link
Member

mosteo commented Sep 12, 2023

OK, after closer inspection this isn't a bug. Alire relies on the manifest from the index, not the one that might be packaged with the sources (as otherwise crates could lie about what they're going to do once download, for example in actions). In fact, such a manifest is moved out of the way after deployment to <crate>/alire/alire.toml.upstream to avoid confusion about this.

So the problem is that the manifest at ~/.config/alire/indexes/als/repo/index/vs/vss/vss-24.0.0-20230529.toml doesn't contain the switches you mention.

Same goes for the configuration extra files.

@mosteo mosteo closed this as completed Sep 12, 2023
@reznikmm
Copy link
Contributor Author

Thank you @mosteo ! Now I see my mistake. I changed vss-24.0.0-20230529.toml and it works now 💎

Sorry for the noise 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: wontfix After consideration, this will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants