feat: add service publish info (#16)

sofastack · Oct 22, 2018 · e3af79a · e3af79a
1 parent 38164c4
commit e3af79a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/lib/client/consumer.js b/lib/client/consumer.js
@@ -144,6 +144,7 @@ class RpcConsumer extends Base {
   }
 
   parseUrl(url) {
+    assert(typeof url === 'string', 'parseUrl(url) url should be string');
     const address = urlparse(url.indexOf('://') >= 0 ? url : `bolt://${url}`, true);
     if (!address.port) {
       address.port = 12200;

diff --git a/lib/server/service.js b/lib/server/service.js
@@ -49,6 +49,8 @@ class RpcService extends Base {
   normalizeReg(url) {
     return {
       interfaceName: this.interfaceName,
+      version: this.version,
+      group: this.group,
       url,
     };
   }

diff --git a/package.json b/package.json
@@ -55,7 +55,7 @@
     "coffee": "^5.1.0",
     "contributors": "^0.5.1",
     "egg-bin": "^4.9.0",
-    "eslint": "^5.6.1",
+    "eslint": "^5.7.0",
     "eslint-config-egg": "^7.1.0",
     "mm": "^2.4.1",
     "pedding": "^1.1.0"

diff --git a/test/server/service.test.js b/test/server/service.test.js
@@ -39,6 +39,13 @@ describe('test/server/service.test.js', () => {
     assert(!service.app);
     assert(!service.registry);
 
+    assert.deepEqual(service.normalizeReg('bolt://127.0.0.1:12200'), {
+      interfaceName: 'com.node.test.TestService',
+      version: '1.0',
+      group: 'SOFA',
+      url: 'bolt://127.0.0.1:12200',
+    });
+
     await service.publish('bolt://127.0.0.1:12200');
     assert(!service.publishUrl);
     await service.unPublish();