[Meshing] simplify input depth map folders #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This metadata was only exported after depth map filter, now it is also exported after depth map estimation.
Add missing metadata after depth map filter.
Conversion of the histogram LOG_INFO to LOG_TRACE for more clarity in the information panel.
1 task
fabiencastan
previously approved these changes
Jun 17, 2020
simogasp
reviewed
Jun 17, 2020
| @@ -168,8 +167,6 @@ int aliceVision_main(int argc, char* argv[]) | |||
| po::options_description optionalParams("Optional parameters"); | |||
| optionalParams.add_options() | |||
| ("depthMapsFolder", po::value<std::string>(&depthMapsFolder), | |||
| "Input depth maps folder.") | |||
There was a problem hiding this comment.
shouldn't the binary version be updated?
fabiencastan
approved these changes
Jun 21, 2020
fabiencastan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Meshing simplification by using only one input folder for depthMaps files.
Thanks to @fabiencastan for his help.
Features list