Add methods in imageMatching #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoleplomb
force-pushed
the
dev/imageMatchingMethods
branch
2 times, most recently
from
e1962ee to
ae26081
Compare
theoleplomb
commented
Jan 23, 2020
theoleplomb
commented
Jan 23, 2020
theoleplomb
commented
Jan 23, 2020
theoleplomb
commented
Jan 23, 2020
theoleplomb
commented
Jan 23, 2020
src/aliceVision/sfm/pipeline/structureFromKnownPoses/StructureEstimationFromKnownPoses.cpp
Outdated
Show resolved
Hide resolved
theoleplomb
force-pushed
the
dev/imageMatchingMethods
branch
from
0ac65c8 to
a4f3b6e
Compare
src/aliceVision/sfm/pipeline/structureFromKnownPoses/StructureEstimationFromKnownPoses.cpp
Outdated
Show resolved
Hide resolved
src/aliceVision/sfm/pipeline/structureFromKnownPoses/StructureEstimationFromKnownPoses.hpp
Outdated
Show resolved
Hide resolved
src/aliceVision/sfm/pipeline/structureFromKnownPoses/StructureEstimationFromKnownPoses.hpp
Outdated
Show resolved
Hide resolved
added 7 commits
January 28, 2020 12:30
The new sequential option can be configured with nbNeighbors.
…h knownPosesGeometricErrorMax
…op and clean cmd line params
fabiencastan
force-pushed
the
dev/imageMatchingMethods
branch
from
0711000 to
326cf4a
Compare
Fix minNum/limitNum conditions.
When computing a SfM node from a previous SfM, the features/matches are not needed.
fabiencastan
force-pushed
the
dev/imageMatchingMethods
branch
from
9cfdc7e to
b592507
Compare
fabiencastan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new methods in ImagesMatching to select best candidates for FeatureMatching.
Expose new parameters in FeatureMatching and SfM.
Features list
Sequentialmethod.Frustumintersection method.methodparam allow to choose between:-- Sequential: based on filenames order
-- Vocabulary Tree
-- Sequential and Vocabulary Tree
-- Exhaustive
-- Frustum: when cameras have known poses, compute frustum intersections
nbNeighborparam in imageMatching for Sequential method.matchFromKnownCameraPosesparamfilterTrackForksparamminNbMatchesparam