Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sfm] bugfix: ceres::AngleAxisRotatePoint cannot be used in-place #696

Merged
merged 1 commit into from
Sep 25, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/aliceVision/sfm/ResidualErrorFunctor.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ struct ResidualErrorFunctor_Pinhole
const T* cam_t = &subpose_Rt[3];

// Rotate the point according to the camera rotation
ceres::AngleAxisRotatePoint(cam_R, pos_proj, pos_proj);
T pos_proj_tmp[3] = { pos_proj[0], pos_proj[1], pos_proj[2] };
ceres::AngleAxisRotatePoint(cam_R, pos_proj_tmp, pos_proj);

// Apply the camera translation
pos_proj[0] += cam_t[0];
Expand Down