Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Modern CMake use as 3rd library #672

Merged
merged 13 commits into from
Aug 7, 2019
Merged

[cmake] Modern CMake use as 3rd library #672

merged 13 commits into from
Aug 7, 2019

Conversation

simogasp
Copy link
Member

@simogasp simogasp commented Jul 24, 2019 •
edited
Loading

Description

It fixes the way the library can be used as third party library using the modern cmake approach (imported targets)

Features list

  • added proper generation of the config file using configure_package_config_file
  • added generation of version file using write_basic_package_version_file
  • rewritten config.in to remove legacy approach
  • removed useless code
  • now exporting targets properly
  • moved the code to retrieve the version before the project declaration so we can also declare the version in the project
  • update the documentation
  • added a sample to test the use of the lib as 3rd party on travis

@simogasp simogasp added this to the 2019.2 milestone Jul 24, 2019
@simogasp simogasp requested a review from fabiencastan July 24, 2019 19:27
@fabiencastan fabiencastan removed this from the 2019.2 milestone Jul 25, 2019
@simogasp simogasp changed the title Modern CMake use as 3rd library [cmake] Modern CMake use as 3rd library Jul 26, 2019
@simogasp simogasp added this to the 2019.2 milestone Aug 7, 2019
@fabiencastan fabiencastan merged commit dba8eb1 into develop Aug 7, 2019
@fabiencastan fabiencastan deleted the modernCmakeFixes branch August 7, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan Awaiting requested review from fabiencastan

Assignees
No one assigned
Labels
scope:build scope:doc type:bug type:enhancement
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.
3 participants
@simogasp @fabiencastan @yann-lty