Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nacos-go data-source extension #62

Closed
louyuting opened this issue Feb 24, 2020 · 4 comments · Fixed by #184
Closed

Add Nacos-go data-source extension #62

louyuting opened this issue Feb 24, 2020 · 4 comments · Fixed by #184
Labels
area/data-source Issues or PRs related to data-source extension area/integrations Issue related to integrations with open-source components good first issue Good for newcomers
Milestone
0.5.0

Comments

@louyuting
Copy link
Collaborator

louyuting commented Feb 24, 2020 •
edited by sczyh30
Loading

Type: feature request

Describe what feature you want

Add Nacos dynamic data-source module for Sentinel. Detailed design is needed.
@louyuting louyuting added kind/feature Category issues or PRs related to feature request area/integrations Issue related to integrations with open-source components labels Feb 24, 2020
@sczyh30 sczyh30 added area/data-source Issues or PRs related to data-source extension good first issue Good for newcomers and removed kind/feature Category issues or PRs related to feature request labels Mar 10, 2020
@sczyh30 sczyh30 changed the title Adapt nacos as dynamic datasource for Sentinel Add Nacos-go data-source extension Mar 10, 2020
@louyuting
Copy link
Collaborator Author

Refer to datasource design:
https://github.com/alibaba/sentinel-golang/wiki/Dynamic-DataSource-Extension-Framework-Design

@binbin0325
Copy link
Collaborator

I want to submit PR for this issue。

@sczyh30
Copy link
Member

sczyh30 commented Jul 7, 2020

I want to submit PR for this issue。

Look forward to your PR! 👍

@binbin0325 binbin0325 mentioned this issue Jul 13, 2020
Merged
@binbin0325
Copy link
Collaborator

@sczyh30 Pr has been submitted.

@sczyh30 sczyh30 added this to the 0.5.0 milestone Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/data-source Issues or PRs related to data-source extension area/integrations Issue related to integrations with open-source components good first issue Good for newcomers
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Nacos datasource
3 participants
@louyuting @sczyh30 @binbin0325