Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of util.CurrentTimeMillis() adaptively under different load conditions #419

Open
sczyh30 opened this issue Jul 22, 2021 · 3 comments
Open

Improve performance of util.CurrentTimeMillis() adaptively under different load conditions #419

sczyh30 opened this issue Jul 22, 2021 · 3 comments
Labels
area/performance Issues or PRs related to runtime performance good first issue Good for newcomers kind/enhancement Category issues or PRs related to enhancement

Comments

@sczyh30
Copy link
Member

sczyh30 commented Jul 22, 2021

Issue Description

Type: feature request

Describe what feature you want

Improve performance (CPU footprint) of util.CurrentTimeMillis() adaptively under different load conditions. Current design of TimeUtil may cost much more than users think in mind in idle systems.

Additional context

Refer alibaba/Sentinel#1746
@sczyh30 sczyh30 added kind/enhancement Category issues or PRs related to enhancement good first issue Good for newcomers area/performance Issues or PRs related to runtime performance labels Jul 22, 2021
@cbl315
Copy link

cbl315 commented Jul 28, 2021

Do we have a bench test result now for util.CurrentTimeMillis()?
It's better to have a base before improve it I think.

@cbl315
Copy link

cbl315 commented Aug 4, 2021

/assign

@sczyh30
Copy link
Member Author

sczyh30 commented Nov 26, 2021

The UseCachedTime feature will be disabled by default in the next version, according to the discussions in #441, #442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/performance Issues or PRs related to runtime performance good first issue Good for newcomers kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbl315 @sczyh30