Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix lxc test error #907

Merged
merged 1 commit into from
Mar 17, 2018

Conversation

Letty5411
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added areas/test kind/bug This is bug report for project size/S labels Mar 16, 2018
@Letty5411 Letty5411 changed the title [bugfix] fix lxc test error bugfix: fix lxc test error Mar 16, 2018
@codecov-io
Copy link

codecov-io commented Mar 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9e3e901). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #907   +/-   ##
========================================
  Coverage          ?   13.7%           
========================================
  Files             ?     121           
  Lines             ?    7648           
  Branches          ?       0           
========================================
  Hits              ?    1048           
  Misses            ?    6510           
  Partials          ?      90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3e901...5bb886a. Read the comment docs.

@allencloud allencloud changed the title bugfix: fix lxc test error bugfix: fix lxc test error Mar 16, 2018
@HusterWan
Copy link
Contributor

Since the TestRunEnableLxcfs case always failed, i will merge this pr, and check whether it will failed again.

FAIL: /go/src/github.com/alibaba/pouch/test/cli_run_test.go:184: PouchRunSuite.TestRunEnableLxcfs
/go/src/github.com/alibaba/pouch/test/cli_run_test.go:192:
    c.Fatalf("upexpected output %s expected %s\n", out, "524288 kB")
... Error: upexpected output  expected 524288 kB

@HusterWan
Copy link
Contributor

LGTM

@HusterWan HusterWan merged commit ddc18e0 into AliyunContainerService:master Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants