Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix volume label error, issue#706 #707

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

Letty5411
Copy link
Contributor

Signed-off-by: letty.ll [email protected]

Ⅰ. Describe what this PR did

fix volume create --label error and add a test.

Ⅱ. Does this pull request fix one issue?

fix #706

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added areas/storage kind/bug This is bug report for project size/S labels Feb 6, 2018
@allencloud
Copy link
Collaborator

LGTM
Waiting CI to be green. 😄

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Feb 6, 2018
@codecov-io
Copy link

Codecov Report

Merging #707 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #707   +/-   ##
======================================
  Coverage    10.7%   10.7%           
======================================
  Files          92      92           
  Lines        5383    5383           
======================================
  Hits          576     576           
  Misses       4757    4757           
  Partials       50      50
Impacted Files Coverage Δ
cli/volume.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d43f7f...f7d502c. Read the comment docs.

@allencloud allencloud merged commit b903ebe into AliyunContainerService:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/storage kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] pouch volume create --label does't work
4 participants