Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make api test error show error message #704

Merged

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun [email protected]

Ⅰ. Describe what this PR did

make api test error show error message, since we found that in CI there is no detailed error message:

10:20:07 /go/src/github.com/alibaba/pouch/test/api_volume_list_test.go:26:
10:20:07     // Create a volume with the name "TestVolume1".
10:20:07     err := CreateVolume(c, "TestVolume1", "local")
10:20:07 /go/src/github.com/alibaba/pouch/test/utils.go:229:
10:20:07     c.Assert(resp.StatusCode, check.Equals, 201)
10:20:07 ... obtained int = 500
10:20:07 ... expected int = 201

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. Describe how you did it

None

Ⅳ. Describe how to verify it

None

Ⅴ. Special notes for reviews

@Letty5411

@pouchrobot pouchrobot added areas/test kind/bug This is bug report for project size/XS labels Feb 6, 2018
@Letty5411
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Feb 6, 2018
@allencloud allencloud merged commit 8246e33 into AliyunContainerService:master Feb 6, 2018
@allencloud allencloud deleted the test-add-failure-msg branch February 6, 2018 05:45
@codecov-io
Copy link

Codecov Report

Merging #704 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #704   +/-   ##
======================================
  Coverage    10.7%   10.7%           
======================================
  Files          92      92           
  Lines        5383    5383           
======================================
  Hits          576     576           
  Misses       4757    4757           
  Partials       50      50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7a2c9...ff9503c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants