Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add parseDeviceMappings test in cli part #692

Merged
merged 1 commit into from
Feb 4, 2018
Merged

test: add parseDeviceMappings test in cli part #692

merged 1 commit into from
Feb 4, 2018

Conversation

ZouRui89
Copy link
Contributor

@ZouRui89 ZouRui89 commented Feb 2, 2018

Signed-off-by: Zou Rui [email protected]

Ⅰ. Describe what this PR did

add parseDeviceMappings test in cli part

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Feb 2, 2018

Codecov Report

Merging #692 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage    9.97%   10.15%   +0.18%     
==========================================
  Files          92       92              
  Lines        5375     5375              
==========================================
+ Hits          536      546      +10     
+ Misses       4789     4779      -10     
  Partials       50       50
Impacted Files Coverage Δ
cli/container.go 31.7% <0%> (+6.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3fe994...57d9f8b. Read the comment docs.

@allencloud
Copy link
Collaborator

LGTM, thanks a lot for your work. @ZouRui89

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Feb 4, 2018
@allencloud allencloud merged commit d53ecb6 into AliyunContainerService:master Feb 4, 2018
@ZouRui89 ZouRui89 deleted the test branch February 5, 2018 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants