Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: remove duplicate TypeUrl initialize #2082

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

HusterWan
Copy link
Contributor

Signed-off-by: Michael Wan [email protected]

Ⅰ. Describe what this PR did

Remove duplicate initialisation of type url containerd.events.ContainerDelete and containerd.events.TaskOOM. Because those type already initialized in vendor

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #2082 into master will increase coverage by 24.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
+ Coverage   39.41%   64.11%   +24.7%     
==========================================
  Files         212      212              
  Lines       16462    16458       -4     
==========================================
+ Hits         6488    10552    +4064     
+ Misses       8955     4598    -4357     
- Partials     1019     1308     +289
Flag Coverage Δ
#criv1alpha1test 32.95% <ø> (+24.73%) ⬆️
#criv1alpha2test 33.55% <ø> (?)
#integrationtest 39.36% <ø> (-0.05%) ⬇️
#unittest 23.69% <ø> (?)
Impacted Files Coverage Δ
ctrd/client.go 56.87% <ø> (-0.21%) ⬇️
ctrd/events.go 75% <ø> (-6.82%) ⬇️
daemon/mgr/container_storage.go 49.48% <0%> (+0.51%) ⬆️
daemon/daemon.go 58.79% <0%> (+1.09%) ⬆️
ctrd/container.go 43.5% <0%> (+1.44%) ⬆️
ctrd/image.go 78.94% <0%> (+1.75%) ⬆️
pkg/meta/store.go 59.52% <0%> (+2.38%) ⬆️
apis/server/utils.go 66.66% <0%> (+2.38%) ⬆️
daemon/mgr/container.go 55.86% <0%> (+2.67%) ⬆️
pkg/user/user.go 75.75% <0%> (+3.03%) ⬆️
... and 101 more

@fuweid
Copy link
Contributor

fuweid commented Aug 13, 2018

LGTM

@fuweid fuweid merged commit e0111ac into AliyunContainerService:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants