bugfix: failed to start container when /etc/mtab is symbol link #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
added
the
priority/P1
HusterWan
reviewed
Aug 2, 2018
| @@ -145,7 +145,7 @@ func setMountTab(ctx context.Context, c *Container, spec *SpecWrapper) error { | |||
|
|
|||
| mtabPrestart := specs.Hook{ | |||
| Path: "/bin/cp", | |||
| Args: []string{"-f", hostmtabPath, mtabPath}, | |||
| Args: []string{"-f", "--remove-destination", hostmtabPath, mtabPath}, | |||
In some images, `/etc/mtab` is symbol link file, such as: `/etc/mtab -> /proc/mounts`, when use `/bin/cp -f` to overwrite `/etc/mtab`, it will cause error, because it will link to `/proc/mounts` file on the host. So we use the option of `--remove-destination` to remove the symbol file before overwrite it. Signed-off-by: Rudy Zhang <[email protected]>
fuweid
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
In some images,
/etc/mtabis symbol link file, such as:/etc/mtab -> /proc/mounts, when use/bin/cp -fto overwrite/etc/mtab, it will cause error, because it will link to/proc/mountsfile on the host.
So we use the option of
--remove-destinationto remove the symbol filebefore overwrite it.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
run testcase
TestRunWithMtabⅤ. Special notes for reviews
Signed-off-by: Rudy Zhang [email protected]