refactor: rm deadcode in storage/volume #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Sun <[email protected]>
allencloud
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2027 +/- ##
=========================================
Coverage ? 63.37%
=========================================
Files ? 200
Lines ? 15500
Branches ? 0
=========================================
Hits ? 9823
Misses ? 4436
Partials ? 1241
|
|
LGTM |
pouchrobot
added
the
LGTM
This was referenced Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
rm some deadcode detected by deadcode.
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Describe how you did it
None
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none