Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix incorrect error judging in core_test.go #1823

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

jiapengcs
Copy link
Contributor

@jiapengcs jiapengcs commented Jul 24, 2018

Ⅰ. Describe what this PR did

correct a mistake in storage/volume/core_test.go, located on line 202, function TestRemoveVolume. After calling core.CreateVolume, we should judge err1, instead of err:

v1, err1 := core.CreateVolume(volid1)
if err != nil {
	t.Fatalf("create volume error: %v", err1)
}

Ⅱ. Does this pull request fix one issue?

fixes #1820

Ⅲ. Describe how you did it

modified the variable from err to err1

Ⅳ. Describe how to verify it

None

Ⅴ. Special notes for reviews

None

@pouchrobot
Copy link
Collaborator

@jiapengcs Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @jiapengcs
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #1823 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
- Coverage    56.3%   56.17%   -0.13%     
==========================================
  Files         200      200              
  Lines       15657    15659       +2     
==========================================
- Hits         8816     8797      -19     
- Misses       5745     5766      +21     
  Partials     1096     1096
Flag Coverage Δ
#critest 33.52% <ø> (+0.04%) ⬆️
#integrationtest 37.29% <ø> (-0.37%) ⬇️
#unittest 20.32% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
daemon/containerio/hijack_conn.go 77.14% <0%> (-11.43%) ⬇️
daemon/containerio/container_io.go 69.61% <0%> (-4.98%) ⬇️
pkg/meta/store.go 54.76% <0%> (-4.77%) ⬇️
daemon/containerio/options.go 76.19% <0%> (-4.77%) ⬇️
daemon/mgr/container_utils.go 56.27% <0%> (-1.74%) ⬇️
daemon/mgr/system.go 73.27% <0%> (-1.73%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
daemon/containerio/cio.go 62.5% <0%> (-1%) ⬇️
daemon/mgr/container.go 53.3% <0%> (+0.15%) ⬆️
cri/v1alpha2/cri.go 66.13% <0%> (+0.17%) ⬆️
... and 2 more

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 24, 2018
@allencloud allencloud changed the title fixes #1820, baiji-group=264-3 test: fix incorrect error judging in core_test.go Jul 24, 2018
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Jul 24, 2018
@allencloud allencloud merged commit 18ca1b5 into AliyunContainerService:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Mistake in storage/volume/core_test.go, baiji-group=264-3
4 participants