Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add placeholder of several test case for baiji developer #1628

Merged

Conversation

zhuangqh
Copy link
Contributor

@zhuangqh zhuangqh commented Jul 5, 2018

Signed-off-by: zhuangqh [email protected]

Ⅰ. Describe what this PR did

Add placeholder of several test case for contributors.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jul 5, 2018

Codecov Report

Merging #1628 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
+ Coverage   41.45%   41.68%   +0.22%     
==========================================
  Files         273      273              
  Lines       17714    17714              
==========================================
+ Hits         7344     7384      +40     
+ Misses       9461     9429      -32     
+ Partials      909      901       -8
Impacted Files Coverage Δ
ctrd/client.go 44.44% <0%> (-10.5%) ⬇️
main.go 60.68% <0%> (-2.07%) ⬇️
daemon/mgr/container.go 50.54% <0%> (+0.15%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
daemon/mgr/system.go 75% <0%> (+1.72%) ⬆️
daemon/mgr/container_utils.go 56.7% <0%> (+1.73%) ⬆️
daemon/containerio/options.go 50.79% <0%> (+4.76%) ⬆️
daemon/containerio/cio.go 63.49% <0%> (+4.76%) ⬆️
apis/server/utils.go 66.66% <0%> (+4.76%) ⬆️
pkg/meta/store.go 59.52% <0%> (+4.76%) ⬆️
... and 2 more

@allencloud
Copy link
Collaborator

Is this ready for merging? I think this just add some framework or example in test. And this will not affect the code base?
If you confirm OK to merge, we could merge this. @zhuangqh

@zhuangqh
Copy link
Contributor Author

zhuangqh commented Jul 6, 2018

yep. Please merge. @allencloud

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 9, 2018
@allencloud allencloud merged commit 047c26f into AliyunContainerService:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants