Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: bind an address for stream server #1520

Merged

Conversation

YaoZengzeng
Copy link
Contributor

@YaoZengzeng YaoZengzeng commented Jun 13, 2018

Signed-off-by: YaoZengzeng [email protected]

Ⅰ. Describe what this PR did

The stream sever should bind an system interface, otherwise the URL it return will be like:

"http://:10010/exec/oM5ZZlm3"

So as mentioned in issue #1516 , we can't exec the pod from other nodes.

If the URL is lack of ip address, it will be localhost by default.

However the pod is not in the local node, so the local stream server will return 404.

Ⅱ. Does this pull request fix one issue?

#1516

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XL labels Jun 13, 2018
@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #1520 into master will decrease coverage by 1.18%.
The diff coverage is 84.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
- Coverage   40.75%   39.57%   -1.19%     
==========================================
  Files         256      255       -1     
  Lines       16756    17674     +918     
==========================================
+ Hits         6829     6994     +165     
- Misses       9048     9802     +754     
+ Partials      879      878       -1
Impacted Files Coverage Δ
cri/v1alpha1/cri_stream.go 0% <0%> (ø) ⬆️
cri/v1alpha2/cri_stream.go 0% <0%> (ø) ⬆️
pkg/net/interface.go 89.06% <89.06%> (ø)
apis/server/container_bridge.go 60% <0%> (-23.7%) ⬇️
apis/server/router.go 75.14% <0%> (-16.22%) ⬇️
daemon/mgr/container_state.go 67.07% <0%> (-15.02%) ⬇️
daemon/mgr/container.go 34.22% <0%> (-14.84%) ⬇️
cli/main.go 0% <0%> (ø) ⬆️
cri/v1alpha1/cri.go 0% <0%> (ø) ⬆️
cri/v1alpha2/cri.go 0% <0%> (ø) ⬆️
... and 4 more

@YaoZengzeng
Copy link
Contributor Author

@allencloud PTAL

@allencloud
Copy link
Collaborator

I think the common functions which are related to network could be moved to pkg.

@YaoZengzeng YaoZengzeng force-pushed the refactor-stream branch 5 times, most recently from 484ae1d to 7218569 Compare June 14, 2018 09:43
@YaoZengzeng
Copy link
Contributor Author

@allencloud Updated

@allencloud
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants