-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: bind an address for stream server #1520
Merged
allencloud
merged 1 commit into
AliyunContainerService:master
from
YaoZengzeng:refactor-stream
Jun 19, 2018
Merged
bugfix: bind an address for stream server #1520
allencloud
merged 1 commit into
AliyunContainerService:master
from
YaoZengzeng:refactor-stream
Jun 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaoZengzeng
force-pushed
the
refactor-stream
branch
from
June 13, 2018 10:01
53b72d7
to
7ef03e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1520 +/- ##
==========================================
- Coverage 40.75% 39.57% -1.19%
==========================================
Files 256 255 -1
Lines 16756 17674 +918
==========================================
+ Hits 6829 6994 +165
- Misses 9048 9802 +754
+ Partials 879 878 -1
|
@allencloud PTAL |
YaoZengzeng
force-pushed
the
refactor-stream
branch
from
June 14, 2018 09:08
7ef03e6
to
feab196
Compare
I think the common functions which are related to network could be moved to pkg. |
YaoZengzeng
force-pushed
the
refactor-stream
branch
5 times, most recently
from
June 14, 2018 09:43
484ae1d
to
7218569
Compare
Signed-off-by: YaoZengzeng <[email protected]>
YaoZengzeng
force-pushed
the
refactor-stream
branch
from
June 14, 2018 11:42
7218569
to
d8ba256
Compare
@allencloud Updated |
LGTM |
This was referenced Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
The stream sever should bind an system interface, otherwise the URL it return will be like:
"http://:10010/exec/oM5ZZlm3"
So as mentioned in issue #1516 , we can't exec the pod from other nodes.
If the URL is lack of ip address, it will be localhost by default.
However the pod is not in the local node, so the local stream server will return 404.
Ⅱ. Does this pull request fix one issue?
#1516
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews