fix: make json ID be Id to be compatible #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Sun <[email protected]>
allencloud
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
==========================================
- Coverage 16.59% 16.08% -0.52%
==========================================
Files 158 158
Lines 8731 8694 -37
==========================================
- Hits 1449 1398 -51
- Misses 7178 7196 +18
+ Partials 104 100 -4
|
|
The codecov goes crazy. 😢 |
|
LGTM in network module. |
pouchrobot
added
the
LGTM
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
We found that in Moby 1.12.6, lots of API communication uses json to wrap data. However, in Moby 1.12.6, almost all field ID is in json format
Idwhich is one upper-case and the other islower-case. While in the master code of Pouch, we useIDin json format. It will leads to incompatibility there. This PR tries to fix that.Ⅱ. Does this pull request fix one issue?
fix one part of #977
Ⅲ. Describe how you did it
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none