bugfix: distinguish cmd and entrypoint better #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YaoZengzeng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1045 +/- ##
==========================================
- Coverage 15.68% 15.68% -0.01%
==========================================
Files 139 139
Lines 8499 8500 +1
==========================================
Hits 1333 1333
- Misses 7066 7067 +1
Partials 100 100
Continue to review full report at Codecov.
|
|
@allencloud PTAL With this PR being merged, the node-e2e-test result of k8s + pouch will be: Ran 186 of 258 Specs in 1673.546 seconds |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YaoZengzeng [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
In order to be consistent with Docker:
User has specified container's entrypoint, don't use the cmd of image's configuration to fill it , even if it is empty.
User has not specified container's entrypoing, use the entrypoint of image's configuration to fill it, as well as cmd.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews