FIX When the namespace does not exist, it is still possible to create configuration items #12890
Conversation
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12890 +/- ##
=============================================
+ Coverage 72.25% 72.27% +0.01%
- Complexity 9826 9829 +3
=============================================
Files 1287 1287
Lines 41445 41458 +13
Branches 4373 4374 +1
=============================================
+ Hits 29947 29962 +15
+ Misses 9396 9395 -1
+ Partials 2102 2101 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
|
|
|
|
@fuhouyu would you please fix namespace existing checking on naming module together on this pr ? |
Ok, I will move the logic of this empty tenant check to the naming module over the weekend |
I see that the parameter validation in the code is placed in the core module, so the validation logic of this namespace is placed under the remoteFilter and paramFilter in the core module. |
|
|
|
|
|
|
|
|
|
|
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
resolve #12889
FIX When the namespace does not exist, configuration items can still be created.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.