Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if RpcClient.request() method request timout, so retryTimes param will be invalid. #12701

Open
XiaZhouxx opened this issue Sep 29, 2024 · 5 comments
Labels
status/wontfix This will not be worked on

Comments

@XiaZhouxx
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@XiaZhouxx
Copy link
Contributor Author

XiaZhouxx commented Sep 29, 2024

image 这里的判断是判定while逻辑整体超时, 但Connection.request内部才是真正的请求超时, 这里应该只需要感知错误然后重试。

@KomachiSion
Copy link
Collaborator

我理解这里不需要修改, 因为timeout是由外部传入的, 也就是预期这次调用最大的超时时间,而不是单次重试的超时时间。

@KomachiSion KomachiSion added the status/wontfix This will not be worked on label Sep 30, 2024
@XiaZhouxx
Copy link
Contributor Author

主要这里我基于官方文档理解这两个参数应该是控制的grpc请求的超时/重试, 并不是调用这个方法的最大超时时间
image

@KomachiSion
Copy link
Collaborator

@shiyiyue1102 一起看一下, 这个超时时间应该是整体的还是单次的?

@shiyiyue1102
Copy link
Collaborator

这个超时是从接口调用方视角的超时时间

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants