prevents potential deadlocks and improves thread safety. #2110
+84
−59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
ConfigFeedbackReceiver
class in thecore/config/feedbacker/ConfigFeedbackReceiver.cpp
file. The main goal of these changes is to improve thread safety by ensuring that theFeedback*ConfigStatus
methods do not hold a lock while calling theFeedback*ConfigStatus
methods on thefeedbackable
objects.Thread safety improvements:
core/config/feedbacker/ConfigFeedbackReceiver.cpp
: Modified theFeedbackContinuousPipelineConfigStatus
,FeedbackInstanceConfigStatus
, andFeedbackOnetimePipelineConfigStatus
methods to first find and store thefeedbackable
object under a lock, and then call the correspondingFeedback*ConfigStatus
method outside the lock. This prevents potential deadlocks and improves thread safety.