-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ebpf plugins #2049
Open
KayzzzZ
wants to merge
87
commits into
alibaba:dev/ebpf_observe
Choose a base branch
from
KayzzzZ:ql/add-coolbpf
base: dev/ebpf_observe
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add ebpf plugins #2049
+25,897
−2,614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KayzzzZ
commented
Jan 19, 2025
•
edited
Loading
edited
- 引入 coolbpf 子模块,作为 bpf 底座
- 新增 ebpf driver 目录,作为 coolbpf 的驱动
- AbstractManager 将负责管理每个 eBPF 插件,所有的 AbstractManagers 由 eBPFServer 管理
- SourceManager 仍然负责与 ebpf driver 交互,不过 eBPF Server 不再直接调用 SourceManager,转而由 AbstractManager 来调用
- 整体包括三组线程:Poller 线程负责拉取 eBPF PerfBuffer;Handler 线程负责处理 eBPF 事件;Scheduler 线程负责定时将聚合后的数据写入到 ProcessQueue 中
2. add sampler 3. add some ut
2. add ebpf wrapper ut 3. add ebpf map traits ut
yyuuttaaoo
reviewed
Feb 20, 2025
yyuuttaaoo
reviewed
Feb 20, 2025
yyuuttaaoo
reviewed
Feb 20, 2025
LOG_ERROR(sLogger, ("user thread, proc is null", "")); | ||
return 1; | ||
} | ||
event->msg->common.size = MSG_UNIX_SIZE + proc->psize + proc->size; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proc->psize 和 proc->size从未赋值
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看了下代码,我们的逻辑里面,对于 /proc 目录读取的进程,这个参数没有用到,可以删掉这个赋值。
对于内核里面 poll 到的event,我们需要common.size 来判断 args 里面到底有多少数据。
yyuuttaaoo
reviewed
Feb 20, 2025
yyuuttaaoo
reviewed
Feb 20, 2025
yyuuttaaoo
reviewed
Feb 20, 2025
yyuuttaaoo
reviewed
Feb 20, 2025
yyuuttaaoo
reviewed
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.