Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue): fix unmount a field in a wrong lifecycle function.(#1609) #1611

Merged
merged 1 commit into from
Jun 21, 2021
Merged

fix(vue): fix unmount a field in a wrong lifecycle function.(#1609) #1611

merged 1 commit into from
Jun 21, 2021

Conversation

MisicDemone
Copy link
Collaborator

@MisicDemone MisicDemone commented Jun 21, 2021 •
edited
Loading

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content

What have you changed?

fix unmount a field in a wrong lifecycle function.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2021 •
edited
Loading

Codecov Report

Merging #1611 (a6c0738) into formily_next (45e9e7f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           formily_next    #1611   +/-   ##
=============================================
  Coverage         89.37%   89.37%           
=============================================
  Files               134      134           
  Lines              6183     6184    +1     
  Branches           1541     1542    +1     
=============================================
+ Hits               5526     5527    +1     
  Misses              652      652           
  Partials              5        5
Impacted Files Coverage Δ
packages/vue/src/hooks/useAttach.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e9e7f...a6c0738. Read the comment docs.

@janryWang janryWang merged commit 2689648 into alibaba:formily_next Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MisicDemone @codecov-commenter @janryWang