fix(core): fix createForm memory leak

alibaba · Jun 13, 2021 · 5f11459 · 5f11459
1 parent ffce36c
commit 5f11459
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 2 deletions.
diff --git a/designable/antd/playground/template.ejs b/designable/antd/playground/template.ejs
@@ -11,5 +11,4 @@
   <script src="https://unpkg.com/react/umd/react.development.js"></script>
   <script src="https://unpkg.com/react-dom/umd/react-dom.development.js"></script>
   <script src="https://unpkg.com/antd/dist/antd-with-locales.min.js"></script>
-  <script src="https://unpkg.com/@formily/reactive/dist/formily.reactive.umd.development.js"></script>
 </body>
diff --git a/designable/antd/playground/webpack.base.ts b/designable/antd/playground/webpack.base.ts
@@ -43,7 +43,6 @@ export default {
     alias: getWorkspaceAlias(),
   },
   externals: {
-    '@formily/reactive': 'Formily.Reactive',
     react: 'React',
     'react-dom': 'ReactDOM',
     moment: 'moment',

diff --git a/packages/core/src/models/Form.ts b/packages/core/src/models/Form.ts
@@ -601,6 +601,7 @@ export class Form<ValueType extends object = any> {
   }
 
   onUnmount = () => {
+    this.disposers.forEach((dispose) => dispose())
     this.query('*').forEach((field) => field.dispose())
     this.unmounted = true
     this.fields = {}