fix(antd/next): fix tool methods and provide simple unit tests (#2694)

alibaba · Dec 29, 2021 · 475d10e · 475d10e
1 parent 9ebdd9c
commit 475d10e
Show file tree

Hide file tree

Showing 4 changed files with 114 additions and 6 deletions.
diff --git a/packages/antd/__tests__/moment.spec.ts b/packages/antd/__tests__/moment.spec.ts
@@ -0,0 +1,48 @@
+import moment from 'moment'
+import { formatMomentValue, momentable } from '../src/__builtins__/moment'
+
+test('momentable is usable', () => {
+  expect(moment.isMoment(momentable('2021-09-08'))).toBe(true)
+  expect(
+    momentable(['2021-09-08', '2021-12-29']).every((item) =>
+      moment.isMoment(item)
+    )
+  ).toBe(true)
+})
+
+test('formatMomentValue is usable', () => {
+  expect(formatMomentValue('', 'YYYY-MM-DD', '~')).toBe('~')
+  expect(formatMomentValue('2021-12-21 15:47:00', 'YYYY-MM-DD')).toBe(
+    '2021-12-21'
+  )
+  expect(formatMomentValue('2021-12-21 15:47:00', undefined)).toBe(
+    '2021-12-21 15:47:00'
+  )
+  expect(formatMomentValue('2021-12-21 15:47:00', (date: string) => date)).toBe(
+    '2021-12-21 15:47:00'
+  )
+  expect(
+    formatMomentValue(
+      ['2021-12-21 15:47:00', '2021-12-29 15:47:00'],
+      'YYYY-MM-DD'
+    )
+  ).toEqual(['2021-12-21', '2021-12-29'])
+  expect(
+    formatMomentValue(
+      ['2021-12-21 16:47:00', '2021-12-29 18:47:00'],
+      (date: string) => date
+    )
+  ).toEqual(['2021-12-21 16:47:00', '2021-12-29 18:47:00'])
+  expect(
+    formatMomentValue(
+      ['2021-12-21 16:47:00', '2021-12-29 18:47:00'],
+      ['YYYY-MM-DD', (date: string) => date]
+    )
+  ).toEqual(['2021-12-21', '2021-12-29 18:47:00'])
+  expect(
+    formatMomentValue(
+      ['2021-12-21 16:47:00', '2021-12-29 18:47:00'],
+      ['YYYY-MM-DD', undefined]
+    )
+  ).toEqual(['2021-12-21', '2021-12-29 18:47:00'])
+})
diff --git a/packages/antd/src/__builtins__/moment.ts b/packages/antd/src/__builtins__/moment.ts
@@ -1,4 +1,4 @@
-import { isArr, isFn } from '@formily/shared'
+import { isArr, isFn, isEmpty } from '@formily/shared'
 import moment from 'moment'
 
 export const momentable = (value: any, format?: string) => {
@@ -21,12 +21,18 @@ export const formatMomentValue = (
       if (isFn(_format)) {
         return _format(date)
       }
-      return date?.format ? date.format(_format) : date
+      if (isEmpty(_format)) {
+        return date
+      }
+      return moment(date).format(_format)
     } else {
       if (isFn(format)) {
         return format(date)
       }
-      return date?.format ? date.format(format) : date
+      if (isEmpty(format)) {
+        return date
+      }
+      return moment(date).format(format)
     }
   }
   if (isArr(value)) {

diff --git a/packages/next/__tests__/moment.spec.ts b/packages/next/__tests__/moment.spec.ts
@@ -0,0 +1,48 @@
+import { momentable, formatMomentValue } from '../src/__builtins__/moment'
+import moment from 'moment'
+
+test('momentable is usable', () => {
+  expect(moment.isMoment(momentable('2021-09-08'))).toBe(true)
+  expect(
+    momentable(['2021-09-08', '2021-12-29']).every((item) =>
+      moment.isMoment(item)
+    )
+  ).toBe(true)
+})
+
+test('formatMomentValue is usable', () => {
+  expect(formatMomentValue('', 'YYYY-MM-DD', '~')).toBe('~')
+  expect(formatMomentValue('2021-12-22 15:47:00', 'YYYY-MM-DD')).toBe(
+    '2021-12-22'
+  )
+  expect(formatMomentValue('2021-12-23 15:47:00', undefined)).toBe(
+    '2021-12-23 15:47:00'
+  )
+  expect(formatMomentValue('2021-12-21 15:47:00', (date: string) => date)).toBe(
+    '2021-12-21 15:47:00'
+  )
+  expect(
+    formatMomentValue(
+      ['2021-12-21 15:47:00', '2021-12-29 15:47:00'],
+      'YYYY-MM-DD'
+    )
+  ).toEqual(['2021-12-21', '2021-12-29'])
+  expect(
+    formatMomentValue(
+      ['2021-12-21 16:47:00', '2021-12-29 18:47:00'],
+      (date: string) => date
+    )
+  ).toEqual(['2021-12-21 16:47:00', '2021-12-29 18:47:00'])
+  expect(
+    formatMomentValue(
+      ['2021-12-21 16:47:00', '2021-12-29 18:47:00'],
+      ['YYYY-MM-DD', (date: string) => date]
+    )
+  ).toEqual(['2021-12-21', '2021-12-29 18:47:00'])
+  expect(
+    formatMomentValue(
+      ['2021-12-21 16:47:00', '2021-12-29 18:47:00'],
+      ['YYYY-MM-DD', undefined]
+    )
+  ).toEqual(['2021-12-21', '2021-12-29 18:47:00'])
+})
diff --git a/packages/next/src/__builtins__/moment.ts b/packages/next/src/__builtins__/moment.ts
@@ -1,4 +1,4 @@
-import { isArr, isFn } from '@formily/shared'
+import { isArr, isEmpty, isFn } from '@formily/shared'
 import moment from 'moment'
 
 export const momentable = (value: any, format?: string) => {
@@ -21,12 +21,18 @@ export const formatMomentValue = (
       if (isFn(_format)) {
         return _format(date)
       }
-      return date?.format ? date.format(_format) : date
+      if (isEmpty(_format)) {
+        return date
+      }
+      return moment(date).format(_format)
     } else {
       if (isFn(format)) {
         return format(date)
       }
-      return date?.format ? date.format(format) : date
+      if (isEmpty(format)) {
+        return date
+      }
+      return moment(date).format(format)
     }
   }
   if (isArr(value)) {