We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentinel/sentinel-core/src/main/java/com/alibaba/csp/sentinel/eagleeye/EagleEyeCoreUtils.java
Lines 142 to 148 in a524ab3
Sentinel/sentinel-core/src/main/java/com/alibaba/csp/sentinel/log/jul/CspFormatter.java
Lines 28 to 34 in a524ab3
Sentinel/sentinel-core/src/main/java/com/alibaba/csp/sentinel/log/jul/DateFileLogHandler.java
Lines 36 to 42 in a524ab3
代码中的ThreadLocal对Java21中的 virtual thread 并不友好。
而且从Java8开始已经推荐使用 java.time.format.DateTimeFormatter,这是一个 "This class is immutable and thread-safe." 的实现。
java.time.format.DateTimeFormatter
是否可以将这些地方换成 java.time.format.DateTimeFormatter?
如果可以的话,我愿意提PR
The text was updated successfully, but these errors were encountered:
是可以这样修改的,欢迎提交这个PR。
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Issue Description
Sentinel/sentinel-core/src/main/java/com/alibaba/csp/sentinel/eagleeye/EagleEyeCoreUtils.java
Lines 142 to 148 in a524ab3
Sentinel/sentinel-core/src/main/java/com/alibaba/csp/sentinel/log/jul/CspFormatter.java
Lines 28 to 34 in a524ab3
Sentinel/sentinel-core/src/main/java/com/alibaba/csp/sentinel/log/jul/DateFileLogHandler.java
Lines 36 to 42 in a524ab3
代码中的ThreadLocal对Java21中的 virtual thread 并不友好。
而且从Java8开始已经推荐使用
java.time.format.DateTimeFormatter
,这是一个 "This class is immutable and thread-safe." 的实现。Describe your initial design
是否可以将这些地方换成
java.time.format.DateTimeFormatter
?如果可以的话,我愿意提PR
The text was updated successfully, but these errors were encountered: