Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A problem when using Adam optimizer #91

Closed
wanghh7 opened this issue May 17, 2022 · 2 comments · Fixed by #96
Closed

A problem when using Adam optimizer #91

wanghh7 opened this issue May 17, 2022 · 2 comments · Fixed by #96
Assignees
@DavdGao

Comments

@wanghh7
Copy link
Contributor

wanghh7 commented May 17, 2022

FederatedScope/federatedscope/core/auxiliaries/optimizer_builder.py

Line 14 in 28d325b

**kwargs)

FederatedScope/federatedscope/core/trainers/context.py

Line 108 in 28d325b

momentum=self.cfg.optimizer.momentum)

Adam got an unexpected keyword argument 'momentum'.
@xieyxclack
Copy link
Collaborator

Thanks for pointing out the issue. I have assigned this thread to @DavdGao

@DavdGao DavdGao mentioned this issue May 20, 2022
Merged
@DavdGao
Copy link
Collaborator

DavdGao commented May 25, 2022

The problem is tracked in #96

@DavdGao DavdGao closed this as completed Jun 6, 2022
@xieyxclack xieyxclack linked a pull request Jun 6, 2022 that will close this issue
Support optimizers with different parameters #96
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavdGao DavdGao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support optimizers with different parameters DavdGao/FederatedScope
3 participants
@xieyxclack @wanghh7 @DavdGao