Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The unit tests use the same shared global_cfg #34

Closed
yxdyc opened this issue Apr 22, 2022 · 1 comment
Closed

The unit tests use the same shared global_cfg #34

yxdyc opened this issue Apr 22, 2022 · 1 comment
Assignees
@yxdyc
Labels
bug Something isn't working

Comments

@yxdyc
Copy link
Collaborator

yxdyc commented Apr 22, 2022 •
edited
Loading

The unit tests use the same shared global_cfg, which does not follow our principles for the use of config.

Besides, the backup operation for the configs may be redundant.
This was referenced Apr 22, 2022
Merged
Merged
@yxdyc yxdyc self-assigned this Apr 22, 2022
@yxdyc yxdyc added the bug Something isn't working label Apr 22, 2022
@yxdyc
Copy link
Collaborator Author

yxdyc commented Apr 24, 2022

Solved in #29

@yxdyc yxdyc closed this as completed Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yxdyc yxdyc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yxdyc