Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulation of Trainer class #253

Closed
joneswong opened this issue Jul 21, 2022 · 0 comments · Fixed by #365
Closed

Encapsulation of Trainer class #253

joneswong opened this issue Jul 21, 2022 · 0 comments · Fixed by #365
Labels
enhancement New feature or request

Comments

@joneswong
Copy link
Collaborator

In our design, Trainer class is responsible for encapsulating much training and testing details. Thus, we'd better make it clear: what interfaces are needed for Client class to interact with a trainer. IMO, directly accessing a trainer's property (e.g., context) should be forbidden:

self.trainer.ctx.num_train_batch

Only in this way can our users develop a trainer in their own ways, respecting these interfaces while totally ignoring our design of the base trainer.

@joneswong joneswong added the enhancement New feature or request label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant