You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In our design, Trainer class is responsible for encapsulating much training and testing details. Thus, we'd better make it clear: what interfaces are needed for Client class to interact with a trainer. IMO, directly accessing a trainer's property (e.g., context) should be forbidden:
In our design,
Trainer
class is responsible for encapsulating much training and testing details. Thus, we'd better make it clear: what interfaces are needed forClient
class to interact with a trainer. IMO, directly accessing a trainer's property (e.g., context) should be forbidden:FederatedScope/federatedscope/core/worker/client.py
Line 413 in bc6eb8b
Only in this way can our users develop a trainer in their own ways, respecting these interfaces while totally ignoring our design of the base trainer.
The text was updated successfully, but these errors were encountered: