Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set different data related parameters for different clients. #186

Closed
DavdGao opened this issue Jun 24, 2022 · 2 comments · Fixed by #365
Closed

Cannot set different data related parameters for different clients. #186

DavdGao opened this issue Jun 24, 2022 · 2 comments · Fixed by #365
Labels
bug Something isn't working

Comments

@DavdGao
Copy link
Collaborator

DavdGao commented Jun 24, 2022

As the title says, since the dataset is loaded before both fedrunner.run() and the setup of clients, the config_per_client.yaml doesn't work for the dataset, such as different batch size.

@DavdGao DavdGao added the bug Something isn't working label Jun 24, 2022
@DavdGao
Copy link
Collaborator Author

DavdGao commented Jun 27, 2022

  • Also, when FS finish the initialization of the global config, all unused configs are removed. However, if someone want to run a certain algorithm for some clients by the --cfg_client xxx.yaml, it will report attribute error since all related parameters within the config have been removed and the default value of cfg.${METHOD_NAME}.__new_allowed__ is False.
  • Another bug is that when combine the global_cfg with the client specific configs, the global_cfg will call the assert function s again. Considering all unused parameters have been removed, some assert function will report attribute errors.

@xieyxclack
Copy link
Collaborator

We need a discussion about how to resolve this issue. @joneswong @yxdyc @rayrayraykk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants