Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: help with protected branch #817

Open
eunjae-lee opened this issue May 12, 2020 · 1 comment
Open

setup: help with protected branch #817

eunjae-lee opened this issue May 12, 2020 · 1 comment

Comments

@eunjae-lee
Copy link
Contributor

When using toReleaseBranch strategy, there can be a possibility that the working branch is protected. It means after release, when Ship.js tries to merge the release branch back to the working branch, it will fail to push the merge commit. In that case, there's nothing much that can be done programmatically.

So if we can check via GitHub API

(1) if this branch is protected
(2) and this branch allows force push,

then we can enable forcePushBranches config by default.

@tyankatsu0105
Copy link
Contributor

It might be inpossible that pushing to protected branch on GitHub Actions...
https://github.community/t5/GitHub-Actions/Allowing-github-actions-bot-to-push-to-protected-branch/m-p/34454#M1924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants