We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shipjs setup
Describe the bug Insert \u002F in ship.config.js
module.exports = { publishCommand: ({ defaultCommand }) => `${defaultCommand} --access public`, mergeStrategy: { toReleaseBranch: { master: "releases" } }, monorepo: { mainVersionFile: "lerna.json", packagesToBump: '["packages\u002F*"]', packagesToPublish: '["packages\u002F*"]' }, buildCommand: () => null };
To Reproduce Steps to reproduce the behavior:
Expected behavior Use / instead of u002F.
/
u002F
Screenshots If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):
node -v
npm -v
yarn -v
Additional context It may cause, here: https://github.com/algolia/shipjs/blob/master/packages/shipjs/src/step/setup/addShipConfig.js#L54
https://www.npmjs.com/package/serialize-javascript#automatic-escaping-of-html-characters
このパッケージの主な機能は、<script>要素のコンテンツとして追加することにより、HTMLドキュメントに埋め込むことができるリテラルJavaScriptの文字列にコードをシリアル化することです。
I think in this case, don't need to use escape.
The text was updated successfully, but these errors were encountered:
Thanks for the report :) Would you like to work on this? As you know @uetchy already provided a way to fix this: https://shipjs.slack.com/archives/CRTUJSCQ7/p1577101355020200
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Describe the bug
Insert \u002F in ship.config.js
To Reproduce
Steps to reproduce the behavior:
shipjs setup
Expected behavior
Use
/
instead ofu002F
.Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):
node -v
: 12.13.0npm -v
oryarn -v
:Additional context
It may cause, here:
https://github.com/algolia/shipjs/blob/master/packages/shipjs/src/step/setup/addShipConfig.js#L54
https://www.npmjs.com/package/serialize-javascript#automatic-escaping-of-html-characters
I think in this case, don't need to use escape.
The text was updated successfully, but these errors were encountered: