Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing hub #401

Closed
3 tasks done
eunjae-lee opened this issue Nov 7, 2019 · 2 comments
Closed
3 tasks done

Replacing hub #401

eunjae-lee opened this issue Nov 7, 2019 · 2 comments

Comments

@eunjae-lee
Copy link
Contributor

eunjae-lee commented Nov 7, 2019

Should we replace hub with something else?
hub is not installed via npm.
It not natural that we have to install it separately.
(Besides, the jobs on CircleCI are failing because for some reason they're failing to install hub on CircleCI)

Initially it was to make it easy for me to ship Ship.js.
Should this be a legit alternative? https://github.com/octokit/rest.js


@jeetiss
Copy link
Contributor

jeetiss commented Nov 12, 2019

it will be nice

Maybe should create github bot for ship.js which will open PRs?

@uetchy
Copy link
Contributor

uetchy commented Nov 22, 2019

I think we should eliminate as many as shell invocations that are basically externally dependent, and alien to the JavaScript ecosystem. rest.js is a great library to communicate with GitHub API and easy to integrate into ship.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants