feat: upload assets to GitHub release

[uetchy]

Adding support for uploading assets to GitHub release.

Fixes #332

[eunjae-lee]

Now that I see your code, I feel like we need to change assetsToUpload to a function returning an array.
The assets to upload can be different from versions. For example, if your bundle is like my-lib-1.2.3.zip, then assetsToUpload needs to dynamically return the file name.

releases: {
  assetsToUpload: ({ version, dir }) => []
}

What do you think? Do you find any other parameters useful there besides version and dir?

[uetchy]

Seems nice! I'm figuring tagName is also useful.

Another possible option is to accept glob pattern.

releases: {
  assetsToUpload: "dist/*.zip"
}

Those options can be considered.

1. singular file, list, function
2. singular file (glob), list (glob)
3. singular file (glob), list (glob), function

[eunjae-lee]

1. singular file, list, function
2. singular file (glob), list (glob)
3. singular file (glob), list (glob), function

3 sounds complete, but you could do 1 first and 3 later if it's too big for you to work on at the moment.

[uetchy]

added

[uetchy]

assetsToUpload accepts both Function and Promises.

[eunjae-lee]

@uetchy
Nice work! It looks good to me.
Can you test one thing?
I'm worried if it won't work when any of path contains a space.
For example, there's a file named /path/hello world.zip, and the command will become
hub release create -a /path/hello world.zip -a /another/file.zip
That space needs to be escaped, but not sure how to properly do it, covering cross platforms.

[uetchy]

@eunjae-lee OK now I added shell-quote to quote asset path containing spaces.
And also wrote a test for them.

It should be cross-platform ready now.

[eunjae-lee]

Congrats and thanks for your contribution. I really appreciate it 🙂

[uetchy]

Awesome😎