From 7d52dbff167f6ec3b5d723ef2fb6b811b794b6ad Mon Sep 17 00:00:00 2001 From: Haroen Viaene Date: Wed, 23 Nov 2022 15:41:25 +0100 Subject: [PATCH] chore(e2e-tests): rewording co-authored-by: Sarah Dayan --- tests/e2e/all-flavors.spec.ts | 22 +++++++++---------- tests/e2e/specs/brand-and-query.spec.ts | 4 ++-- tests/e2e/specs/category.spec.ts | 4 ++-- .../specs/initial-state-from-route.spec.ts | 4 ++-- tests/e2e/specs/pagination.spec.ts | 4 ++-- tests/e2e/specs/price-range.spec.ts | 4 ++-- 6 files changed, 21 insertions(+), 21 deletions(-) diff --git a/tests/e2e/all-flavors.spec.ts b/tests/e2e/all-flavors.spec.ts index 26b29a5f4a2..6a106c3481e 100644 --- a/tests/e2e/all-flavors.spec.ts +++ b/tests/e2e/all-flavors.spec.ts @@ -1,16 +1,16 @@ -import { brandAndQuery } from './specs/brand-and-query.spec'; -import { category } from './specs/category.spec'; -import { initialStateFromRoute } from './specs/initial-state-from-route.spec'; -import { pagination } from './specs/pagination.spec'; -import { priceRange } from './specs/price-range.spec'; -import { flavors } from './flavors'; +import { createBrandAndQueryTestSuite } from './specs/brand-and-query.spec'; +import { createCategoryTestSuite } from './specs/category.spec'; +import { createInitialStateFromRouteTestSuite } from './specs/initial-state-from-route.spec'; +import { createPaginationTestSuite } from './specs/pagination.spec'; +import { createPriceRangeTestSuite } from './specs/price-range.spec'; +import { flavors } from './flavors'; flavors.forEach((flavor) => { describe(`${flavor}`, () => { - brandAndQuery(flavor); - category(flavor); - initialStateFromRoute(flavor); - pagination(flavor); - priceRange(flavor); + createBrandAndQueryTestSuite(flavor); + createCategoryTestSuite(flavor); + createInitialStateFromRouteTestSuite(flavor); + createPaginationTestSuite(flavor); + createPriceRangeTestSuite(flavor); }); }); diff --git a/tests/e2e/specs/brand-and-query.spec.ts b/tests/e2e/specs/brand-and-query.spec.ts index 578758264a6..6642bf93558 100644 --- a/tests/e2e/specs/brand-and-query.spec.ts +++ b/tests/e2e/specs/brand-and-query.spec.ts @@ -1,7 +1,7 @@ -export function brandAndQuery(flavor: string) { +export function createBrandAndQueryTestSuite(flavor: string) { const root = `examples/${flavor}/e-commerce/`; - describe('Search on specific brand and query filtering', () => { + describe('search on specific brand and query filtering', () => { it('navigates to the e-commerce demo', async () => { await browser.url(root); }); diff --git a/tests/e2e/specs/category.spec.ts b/tests/e2e/specs/category.spec.ts index 057ef3a5db7..4cd88fae64b 100644 --- a/tests/e2e/specs/category.spec.ts +++ b/tests/e2e/specs/category.spec.ts @@ -1,7 +1,7 @@ -export function category(flavor: string) { +export function createCategoryTestSuite(flavor: string) { const root = `examples/${flavor}/e-commerce/`; - describe('Search on specific category', () => { + describe('search on specific category', () => { it('navigates to the e-commerce demo', async () => { await browser.url(root); }); diff --git a/tests/e2e/specs/initial-state-from-route.spec.ts b/tests/e2e/specs/initial-state-from-route.spec.ts index 9912716284f..9bec5853aaf 100644 --- a/tests/e2e/specs/initial-state-from-route.spec.ts +++ b/tests/e2e/specs/initial-state-from-route.spec.ts @@ -1,9 +1,9 @@ import { URL, URLSearchParams } from 'url'; -export function initialStateFromRoute(flavor: string) { +export function createInitialStateFromRouteTestSuite(flavor: string) { const root = `examples/${flavor}/e-commerce/`; - describe('State and route', () => { + describe('state and route', () => { describe('read', () => { it('navigates to the e-commerce demo with refinements set in route', async () => { const params = new URLSearchParams({ diff --git a/tests/e2e/specs/pagination.spec.ts b/tests/e2e/specs/pagination.spec.ts index 0895c62604f..8d8beb8c54d 100644 --- a/tests/e2e/specs/pagination.spec.ts +++ b/tests/e2e/specs/pagination.spec.ts @@ -1,7 +1,7 @@ -export function pagination(flavor: string) { +export function createPaginationTestSuite(flavor: string) { const root = `examples/${flavor}/e-commerce/`; - describe('Page navigation', () => { + describe('page navigation', () => { it('navigates to the e-commerce demo', async () => { await browser.url(root); }); diff --git a/tests/e2e/specs/price-range.spec.ts b/tests/e2e/specs/price-range.spec.ts index d993a74da62..0c4dc45ae85 100644 --- a/tests/e2e/specs/price-range.spec.ts +++ b/tests/e2e/specs/price-range.spec.ts @@ -1,7 +1,7 @@ -export function priceRange(flavor: string) { +export function createPriceRangeTestSuite(flavor: string) { const root = `examples/${flavor}/e-commerce/`; - describe('Search on specific price range', () => { + describe('search on specific price range', () => { let lowerBound: number; let upperBound: number;