Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI that runs on PRs of configs #338

Closed
Haroenv opened this issue Aug 9, 2017 · 3 comments
Closed

CI that runs on PRs of configs #338

Haroenv opened this issue Aug 9, 2017 · 3 comments

Comments

@Haroenv
Copy link

Haroenv commented Aug 9, 2017

If it's an existing config, run that one and suggest to update the nbHits in a comment. You could use Danger for this, since it's an easy way to run some things and comment on GitHub.

Another thing that could be checked is whether it's valid JSON, and if it's a valid docsearch config (by checking if necessary keys are present, and if they have the right values), this is related to #326

@lottec
Copy link

lottec commented Nov 27, 2017

Hey, is this likely to be picked up soon?

Currently looking at running the scraper on own infra, adding to our CI pipeline, but if this was likely to be added to the Docsearch offering that'd be amazing...!

@Haroenv
Copy link
Author

Haroenv commented Nov 27, 2017

This isn't done yet, but feel free to open a PR @lottec !

@s-pace
Copy link
Contributor

s-pace commented Jun 22, 2020

Issue addressed thanks to this PR:
algolia/docsearch-configs#2059

@s-pace s-pace closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants