From c33330ea025661ca23cacff4446ba8263734278c Mon Sep 17 00:00:00 2001 From: Sarah Dayan Date: Fri, 2 Apr 2021 11:42:01 +0200 Subject: [PATCH 1/2] fix(examples): fix GitHub example layout --- .../github-repositories-custom-plugin/app.tsx | 1 + .../createGitHubReposPlugin.tsx | 88 ++++++++++--------- 2 files changed, 46 insertions(+), 43 deletions(-) diff --git a/examples/github-repositories-custom-plugin/app.tsx b/examples/github-repositories-custom-plugin/app.tsx index b297010ea..9b25fd918 100644 --- a/examples/github-repositories-custom-plugin/app.tsx +++ b/examples/github-repositories-custom-plugin/app.tsx @@ -11,5 +11,6 @@ const gitHubReposPlugin = createGitHubReposPlugin({ autocomplete({ container: '#autocomplete', + debug: true, plugins: [gitHubReposPlugin], }); diff --git a/examples/github-repositories-custom-plugin/createGitHubReposPlugin.tsx b/examples/github-repositories-custom-plugin/createGitHubReposPlugin.tsx index 703cb2055..993e2c09f 100644 --- a/examples/github-repositories-custom-plugin/createGitHubReposPlugin.tsx +++ b/examples/github-repositories-custom-plugin/createGitHubReposPlugin.tsx @@ -70,55 +70,57 @@ export function createGitHubReposPlugin( return ( -
- {item.full_name} -
-
-
-
{item.full_name}
-
- - - {' '} -
+
+
+
+
{item.full_name}
+
- {stars} - + + + {' '} + +
-
-
- {item.description} +
+ {item.description} +
From 276a1fb2430c52e1c1cda3b21d0f5cd4891d0a08 Mon Sep 17 00:00:00 2001 From: Sarah Dayan Date: Tue, 6 Apr 2021 12:01:46 +0200 Subject: [PATCH 2/2] fix: apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com> --- examples/github-repositories-custom-plugin/app.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/github-repositories-custom-plugin/app.tsx b/examples/github-repositories-custom-plugin/app.tsx index 9b25fd918..b297010ea 100644 --- a/examples/github-repositories-custom-plugin/app.tsx +++ b/examples/github-repositories-custom-plugin/app.tsx @@ -11,6 +11,5 @@ const gitHubReposPlugin = createGitHubReposPlugin({ autocomplete({ container: '#autocomplete', - debug: true, plugins: [gitHubReposPlugin], });