feat(js): sync detached mode open state #556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This synchronizes the internal open state with the detached overlay open state.
It was a missing behavior that caused some trouble to users, unable to trigger an action (other than a link) after a selection on detached mode.
Changes
We're now syncing the detached open state with the internal
isOpen
state. This means thatshouldPanelOpen
always returntrue
on detached mode now. Otherwise, the detached overlay wouldn't be able to stay open under user conditions.Related