Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hint: false has lost it's effect in v0.34.0 #275

Closed
rudissaar opened this issue Dec 12, 2018 · 5 comments
Closed

hint: false has lost it's effect in v0.34.0 #275

rudissaar opened this issue Dec 12, 2018 · 5 comments

Comments

@rudissaar
Copy link

rudissaar commented Dec 12, 2018

I'm using dist/autocomplete.jquery.min.js and since v0.34.0 hint: false is not working anymore.

I tried what happens if I use v0.33.0 instead and found out it indeed works in previous release, it might be a bug.

@Haroenv
Copy link
Contributor

Haroenv commented Dec 12, 2018

No code regarding to that changed between v0.33.0 and v0.34.0, this is really weird. Are you sure the version is the only variant you used while testing? Could you make a sandbox with working & non-working version?

There's a template here: https://codesandbox.io/s/github/algolia/create-instantsearch-app/tree/templates/autocomplete.js

@rudissaar
Copy link
Author

Maybe I miss understood what hint is in autocomplete.js, but my problem really is I get native autocomplete of my previous searches with latest version, but not with previous one, I inspected and it seems by using v0.33.0 input element will have a attribute autocomplete="off",
but by using using v0.34.0 I get: autocomplete="nope"

@Haroenv
Copy link
Contributor

Haroenv commented Dec 13, 2018

ah, hint is not what this is for, hint is used for background text as a placeholder and is unrelated to the behaviour you described. What you are seeing is more of a bug, which behaviour we reverted in #273 and will be back to what the behaviour was in 0.33 in the next version.

@rudissaar
Copy link
Author

Feel free to close this issue then, thanks.

@Haroenv Haroenv closed this as completed Dec 13, 2018
@Haroenv
Copy link
Contributor

Haroenv commented Dec 13, 2018

Feel free to continue using 0.33 until 0.35 is released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants