-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Insights opt-in from the Dashboard #1205
Conversation
Co-authored-by: Dhaya <[email protected]>
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2b3bc8d:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I have listed some questions and suggestions before approving.
packages/autocomplete-core/src/__tests__/createAutocomplete.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-core/src/__tests__/createAutocomplete.test.ts
Outdated
Show resolved
Hide resolved
Thanks for the review @dhayab! I took your feedback into account and also made a small change to never send |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻 🙏🏻
Summary
This enables Insights opt-in from the Dashboard.
Algolia customers can now opt-in to Automatic Insights directly from the Dashboard instead of having to pass the
insights
option totrue
in the code.FX-2644