fix(types): correct type for SearchClient #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some cases this was inferred to `any` instead of the right type, after TS 5.1.3. This fix was also done in the helper: algolia/algoliasearch-helper-js#943 this would have been caught if it was moved in the JS monorepo so the code could be in a shared package, or if we had updated to TS 5.1.3
Haroenv
requested review from
a team,
sarahdayan,
aymeric-giraudet and
dhayab
and removed request for
a team and
aymeric-giraudet
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 30e7443:
|
dhayab
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
in some cases this was inferred to
anyinstead of the right type, after TS 5.1.3.This fix was also done in the helper: algolia/algoliasearch-helper-js#943
this would have been caught if it was moved in the JS monorepo so the code could be in a shared package, or if we had updated to TS 5.1.3
Result
no
anyinferred for SearchClient type