Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete-core): don't update enterKeyHint on Samsung Browser #1153

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

FabienMotte
Copy link
Contributor

@FabienMotte FabienMotte commented Jun 7, 2023

Summary

CR-3619

This PR follows #916 and updates the isSamsung() util regex to detect Samsung Browsers even if the "Desktop Mode" is enabled.

Result

On Samsung Browsers, when the "Desktop Mode" is enabled, enterKeyHint attribute is not updated, resulting in the input value not being reset.

@FabienMotte FabienMotte requested review from a team, Haroenv and aymeric-giraudet and removed request for a team June 7, 2023 10:24
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0dba51e:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

@Haroenv
Copy link
Contributor

Haroenv commented Jun 7, 2023

Maybe only samsungbrowser is needed, but happy to keep a larger target

@FabienMotte
Copy link
Contributor Author

Maybe only samsungbrowser is needed, but happy to keep a larger target

Some tests are not passing anymore, also we need to check for Samsung devices (and not only Samsung browser) since the issue is related to Samsung Predictive Search.

Thanks for your reviews!

@FabienMotte FabienMotte merged commit 2971076 into next Jun 7, 2023
@FabienMotte FabienMotte deleted the fix/samsung-browser-desktop-mode branch June 7, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants