fix(redirect): reopen menu when redirect detected #1091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a redirect item is found after selecting a hit, then reopen the menu with the latest results (notably the redirect item).
Spun off from #1089
After discussing further, consistency of the UX was determined to be the top priority. Before there were situations when a redirect could occur without the user knowing. This approach, while less ideal functionally because two selects/submits are required, will always show a redirect item in the dropdown when the current query will redirect.
Two cases covered in the demo below:
Screen.Recording.2023-02-13.at.8.13.19.AM.mov