-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: duplicated IDs in panel #1078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cb0955b:
|
aymeric-giraudet
requested changes
Jan 31, 2023
aymeric-giraudet
approved these changes
Jan 31, 2023
FabienMotte
commented
Jan 31, 2023
I updated the PR description and added a CodeSandbox with 2 instances, each instance with two sections (= 2 plugins). |
Haroenv
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
CR-2709
Autocomplete is rendering duplicated values for the attribute
id
(see image below,autocomplete-0-list
ID is used in two lists). As described in the HTML specs, the value of theid
attribute must be unique within the HTML document.Summary
ID values currently relies on the
generateAutocompleteId()
method, which is unique per Autocomplete instance but not per source.Autocomplete panel
This PR tries to fix duplicated ID attributes in the Autocomplete panel by using the
sourceIndex
value to get a unique ID value per instance, source and item.The ID value is described as follows:
autocomplete-${instanceId}-${sourceId}-${'list' | 'item' | 'label'}
.Autocomplete search box
For the Autocomplete search box, the ID value is described as follows:
autocomplete-${instanceId}-${'input' | 'label'}
.Result
Outputted ID attribute values are unique.
→ CodeSandbox
Autocomplete instance #1
Search box
Label ID:
autocomplete-0-label
Input ID:
autocomplete-0-input
Panel
Source #1
List ID:
autocomplete-0-0-list
First list item ID:
autocomplete-0-0-item-0
Source #2
List ID:
autocomplete-0-1-list
First list item ID:
autocomplete-0-1-item-5
Autocomplete instance #2
Search box
Label ID:
autocomplete-1-label
Input ID:
autocomplete-1-input
Panel
Source #1
List ID:
autocomplete-1-0-list
First list item ID:
autocomplete-1-0-item-0
Source #2
List ID:
autocomplete-1-1-list
First list item ID:
autocomplete-1-1-item-5