-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(highlighting): support array syntax for nested attributes #418
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7f9a2f6:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test with an attribute that contains a .
to make sure that it works? It's a recurrent problem for our customers.
Example
const hit = {
translations: {
'fr.EN': 'Muggle',
'fr.CA': 'Muggle',
'fr.FR': 'Moldu',
}
}
highlightHit({
hit,
attribute: ['translations', 'fr.FR']
})
A successful test and a test that warns would be great!
packages/autocomplete-preset-algolia/src/highlight/__tests__/parseAlgoliaHitHighlight.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice–good to go with these last changes!
Co-authored-by: François Chalifour <[email protected]>
Summary
Allow
attribute
key to receive astring[]
containing the path of the highlighted element in the hit.TypeScript
I couldn't find a good way to implement deep object pathing, so it's not typed for now. It also looks like that a
PathOf
type isstill discussed.