Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): warn when using debug option #364

Merged
merged 6 commits into from
Nov 10, 2020
Merged

Conversation

francoischalifour
Copy link
Member

This adds a development warning when using the debug option.

This adopts a similar strategy to InstantSearch (algolia/instantsearch#3260) for our bundles as well as our development warnings (algolia/instantsearch#3574).
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e8e36f9:

Sandbox Source
@algolia/js-example Configuration

Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Base automatically changed from feat/development-production-mode to next November 10, 2020 10:47
@francoischalifour francoischalifour merged commit 2a2e3dd into next Nov 10, 2020
@francoischalifour francoischalifour deleted the feat/debug-warning branch November 10, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants